allow adding same components multiple times in 'sequence' using blocks#1050
Closed
hilsonshrestha wants to merge 1 commit into
Closed
allow adding same components multiple times in 'sequence' using blocks#1050hilsonshrestha wants to merge 1 commit into
hilsonshrestha wants to merge 1 commit into
Conversation
|
A preview of is uploaded and can be seen here: ✨ https://revisit.dev/study/PR1050 ✨ Changes may take a few minutes to propagate. |
31 tasks
6 tasks
13 tasks
Contributor
|
It seems this problem was fixed in another way on the current dev branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #1029
Give a longer description of what this PR addresses and why it's needed
Currently, same component cannot be added twice in
sequencerestricting us to reuse components. This also applied to libraries.This PR allows same component name to be in the
sequenceby separating into blocks.Example:
{ "components": [ "introduction", "$demographics.components.demographics", "barChart", { "id": "block1", "order": "fixed", "components": ["barChart"] }, { "id": "block2", "order": "fixed", "components": ["barChart"] }, { "id": "block3", "order": "fixed", "components": ["$demographics.components.demographics"] }, { "id": "block4", "order": "fixed", "components": ["$demographics.components.demographics"] }, { "id": "block5", "order": "fixed", "components": [ { "order": "fixed", "id": "block5-1", "components": ["$demographics.components.demographics"] } ] }, "external_website" ] }